Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Public Safety Impact values consistent throughout #267

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Make Public Safety Impact values consistent throughout #267

merged 1 commit into from
Jul 7, 2023
+226 −227

Conversation

ahouseholder
Copy link
Contributor

fixes #266

Makes Coordinator Triage .csv, tree diagram, .sh, and .json representation consistent with the main document's use of Minimal and Significant as the values of Public Safety Impact rather than Minor and Huge.

@ahouseholder ahouseholder added bug Something isn't working documentation Improvements or additions to documentation labels Jul 7, 2023
@ahouseholder ahouseholder added this to the SSVC v2.1 milestone Jul 7, 2023
@ahouseholder ahouseholder self-assigned this Jul 7, 2023
@ahouseholder ahouseholder linked an issue Jul 7, 2023 that may be closed by this pull request
Public Safety Impact inconsistent usage #266
Closed
@ahouseholder ahouseholder changed the title s/minor/minimal/ s/huge/significant/ in Public Safety Impact usages Make Public Safety Impact values consistent throughout Jul 7, 2023
cgyarbrough
cgyarbrough approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@cgyarbrough cgyarbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with the changes. I like the more accurate labels.

@ahouseholder ahouseholder merged commit 6eb41e5 into main Jul 7, 2023
@ahouseholder ahouseholder deleted the feature/fix_266 branch July 7, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgyarbrough cgyarbrough cgyarbrough approved these changes

@j--- j--- Awaiting requested review from j--- j--- is a code owner

@sei-vsarvepalli sei-vsarvepalli Awaiting requested review from sei-vsarvepalli sei-vsarvepalli is a code owner

@ehatleback ehatleback Awaiting requested review from ehatleback

Assignees

@ahouseholder ahouseholder

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
SSVC v2.1
Development

Successfully merging this pull request may close these issues.

Public Safety Impact inconsistent usage
2 participants
@ahouseholder @cgyarbrough